Add 1.3 erase certificate feature for SET_CERTIFICATE
#2433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wenxing-hou
force-pushed
the
sync_setcert_1.3
branch
2 times, most recently
from
c7a9f75 to
118fd69
Compare
jyao1
reviewed
Nov 15, 2023
jyao1
reviewed
Nov 15, 2023
Wenxing-hou
force-pushed
the
sync_setcert_1.3
branch
2 times, most recently
from
ad26d56 to
0a8f7b7
Compare
jyao1
reviewed
Nov 17, 2023
jyao1
reviewed
Nov 17, 2023
jyao1
reviewed
Nov 17, 2023
jyao1
reviewed
Nov 17, 2023
jyao1
reviewed
Nov 17, 2023
jyao1
reviewed
Nov 20, 2023
jyao1
reviewed
Nov 20, 2023
Wenxing-hou
force-pushed
the
sync_setcert_1.3
branch
2 times, most recently
from
90c20ad to
a0913e6
Compare
jyao1
approved these changes
Nov 20, 2023
steven-bellock
changed the title
SET_CERTIFICATE
steven-bellock
requested changes
Nov 21, 2023
Wenxing-hou
force-pushed
the
sync_setcert_1.3
branch
from
a0913e6 to
966d747
Compare
Wenxing-hou
force-pushed
the
sync_setcert_1.3
branch
from
966d747 to
c3742be
Compare
Wenxing-hou
force-pushed
the
sync_setcert_1.3
branch
3 times, most recently
from
e337b5d to
6d9aa22
Compare
Contributor
Author
|
@steven-bellock Hi Steven, could you review again? I have fixed the code based on your feedback. |
Contributor
|
@Wenxing-hou the comment in https://github.com/DMTF/libspdm/pull/2433/files#r1400951233 is still valid. If the message was sent in a session then libspdm can check the exact size, else it cannot. |
Wenxing-hou
force-pushed
the
sync_setcert_1.3
branch
from
6d9aa22 to
d56fc8a
Compare
Contributor
Author
Thanks. I have fixed the code based on the feedback. |
jyao1
reviewed
Dec 18, 2023
Wenxing-hou
force-pushed
the
sync_setcert_1.3
branch
from
d56fc8a to
91c980c
Compare
Wenxing-hou
force-pushed
the
sync_setcert_1.3
branch
from
91c980c to
02bed09
Compare
Contributor
Author
|
And I have added the table in code comment: libspdm/include/internal/libspdm_responder_lib.h Lines 678 to 690 in 02bed09 |
steven-bellock
requested changes
Dec 27, 2023
Fix the issue: DMTF#2292 Signed-off-by: Wenxing Hou <[email protected]>
Signed-off-by: Wenxing Hou <[email protected]>
Wenxing-hou
force-pushed
the
sync_setcert_1.3
branch
from
02bed09 to
08b571b
Compare
steven-bellock
approved these changes
Jan 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #2292
The code has passed the unit_test.